search

OpenTermsArchive / engine

Tracks contractual documents and exposes changes to the terms of online services.
https://opentermsarchive.org
European Union Public License 1.2
111 stars 30 forks source link

Document setup of `autocrlf` on Windows #1018

Open MattiSG opened 1 year ago

MattiSG commented 1 year ago

autocrlf is set to false both in the CI workflow and in the Git adapter setup.

The latter seems much more reliable, and I worry that the CI setup gives us a false sense of security when our tests run on specifically-configured machines.

Do we really need the CI setup?

MattiSG commented 1 year ago

Beyond this specific case, adding a comment explaining why this setup is needed would be very useful.

Ndpnt commented 7 months ago

I tried to remove it from the CI workflow configuration but it does not work. See https://github.com/OpenTermsArchive/engine/actions/runs/7831447577/job/21369769402

MattiSG commented 7 months ago

Thanks. This thus seems to be needed for Windows, no matter the Git adapter setup. I understand that this should thus be documented for users on Windows.