OpenTermsArchive / engine

Tracks contractual documents and exposes changes to the terms of online services.
https://opentermsarchive.org
European Union Public License 1.2
105 stars 29 forks source link

Update `turndown` by implementing a custom rule #1019

Open MattiSG opened 10 months ago

MattiSG commented 10 months ago

The dependency used to convert HTML into Markdown, turndown, is loaded from a fork to circumvent https://github.com/OpenTermsArchive/engine/issues/903.

However:

According to https://github.com/mixmark-io/turndown/pull/419#issuecomment 1361030545, it is very unlikely https://github.com/OpenTermsArchive/turndown/pull/2 will ever be merged into upstream.

The alternative suggested by the library author is to use a custom rule. This would indeed be a more perennial approach than maintaining our own fork.

(source: https://github.com/OpenTermsArchive/engine/issues/903#issuecomment-1519795731)

This means that until a custom rule is added and the original dependency is brought back, we are stuck with maintaining our own fork.