search

OpenTermsArchive / engine

Tracks contractual documents and exposes changes to the terms of online services.
https://opentermsarchive.org
European Union Public License 1.2
106 stars 30 forks source link

Fix GitHub issue link formatting #970

Closed Kissaki closed 1 year ago

Kissaki commented 1 year ago

Previously, errors were reported on a single line, where the inline code-fencing on message worked.

The current logic is: The html fetcher throws FetchDocumentErrors, with the URL fenced with apostrophe '. Archivist collects these errors in InaccessibleContentError, which produces a multiline error message (generic text + foreach(\n- error)).

Because the message is multiline now, the inline code fencing with backticks no longer worked.

As a side effect, the GitHub URL identification included the closing \'` in the URL. Without the ` the \' is not included in the URL href.

So dropping the now invalid backticks resolves both the invalid backticks and wrong URL linking.

Fixes #967

MattiSG commented 1 year ago

The issue is still present, for example in https://github.com/OpenTermsArchive/france-declarations/issues/258#issuecomment-1336816695. This is because of failing tests in CI which blocked deployment. I opened https://github.com/ambanum/OpenTermsArchive/issues/973 to track progress.