OpenTermsArchive / france-versions

Documents versions for France services. Maintained collaboratively by volunteer contributors.
https://docs.opentermsarchive.org/navigate-history/
10 stars 2 forks source link

Commit messages before 23/03/2022 should be edited #1

Closed Ndpnt closed 2 years ago

Ndpnt commented 2 years ago

There is 3 weeks worth of history in Mongo for France. The commit messages reference commit hashes but these IDs are Mongo IDs, not commit hashes, until 24th of March 2022 and commit sha c067713.

MattiSG commented 2 years ago

I see in 6f999c1ed4d016ed5ff64c9f7c9566c2bb0c5e64 that the identifier length went down to 7 characters, leading me to suspect an actual commit hash, but that the text still refers to a Mongo ID. Is this normal? 🙂

Ndpnt commented 2 years ago

I see in 6f999c1 that the identifier length went down to 7 characters, leading me to suspect an actual commit hash, but that the text still refers to a Mongo ID. Is this normal? 🙂

No it was an error, I fixed it.

Ndpnt commented 2 years ago

Fixed by integration Mongo history and changing references.

MattiSG commented 2 years ago

Thank you! This morning we had a use case where accessing the snapshot directly through the comment was really super useful (a PDF file that is not readable, cf. https://github.com/OpenTermsArchive/france-versions/commit/d4a1f3bea9300e73f7d1c0a9acc23163b51b676d), it's great to see that generalised!