OpenTermsArchive / opentermsarchive.org

https://opentermsarchive.org
European Union Public License 1.2
5 stars 1 forks source link

Improve homepage example accessibility #319

Closed clementbiron closed 6 months ago

clementbiron commented 6 months ago

That changeset increases the lighthouse accessiblity score to 100.

netlify[bot] commented 6 months ago

Deploy Preview for open-terms-archive-website ready!

Name Link
Latest commit 1aea2dfab58231b67e3feaa22bca39b5052bf060
Latest deploy log https://app.netlify.com/sites/open-terms-archive-website/deploys/66324d440e79a9000858d925
Deploy Preview https://deploy-preview-319--open-terms-archive-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

MattiSG commented 6 months ago

I'm sorry, but removing background color highlighting on additions and relying only on text color (green vs white) for hinting might lead to a 100 score for automated tools but is a massive regression in terms of actual accessibility. Please bring back some other visual hints than color only.

image

There are also several typos that should be fixed:

Please be attentive when reviewing.