OpenTerrace / openterrace-python

OpenTerrace: A fast, flexible and extendable Python framework for packed bed thermal energy storage simulations
https://openterrace.github.io/openterrace-python/
GNU General Public License v3.0
20 stars 2 forks source link

Layer numbering #141

Closed AdamRJensen closed 8 months ago

AdamRJensen commented 8 months ago

First, I think it would be very useful including this figure from the JOSS paper in the documentation:

image

Second, it seems that there is an issue with the numbering. The text states that "For each node, the bed material is discretised in M nodes", however if the nodes start at 0 and ends at M, there will be M+1 nodes. I suggest either starting from 1 or ending at M-1.

jakobhaervig commented 8 months ago

Good points @AdamRJensen. I now updated the figure and included the updated figure in the documentation in the theory section: https://openterrace.github.io/openterrace-python/theory/

Closing this one.

AdamRJensen commented 8 months ago

@jakobhaervig The image does not render correctly

jakobhaervig commented 8 months ago

Thanks, please check again.