search

OpenTerrace / openterrace-python

OpenTerrace: A fast, flexible and extendable Python framework for packed bed thermal energy storage simulations
https://openterrace.github.io/openterrace-python/
GNU General Public License v3.0
20 stars 2 forks source link

Mixed use of camelCase and snake_case #145

Closed AdamRJensen closed 8 months ago

AdamRJensen commented 8 months ago

I noticed that the parameter arguments use a mix of camel case (e.g., fixedValue) and snake case (e.g., central_difference)

For example this example in the tutorials:

    fluid.select_schemes(diff='central_difference_1d', conv='upwind_1d')
    fluid.select_initial_conditions(T=273.15+20)
    fluid.select_massflow(mdot=0.1)
    fluid.select_bc(bc_type='fixedValue',
jakobhaervig commented 8 months ago

Thanks, this should now be consistent throughout using PEP 8.

Closing this one.