JOSS Review: Software Paper

baperry2 commented 4 months ago

This issue includes comments that should be addressed to resolve the "Software Paper" portion of the review checklist:

[x] The summary describes the purpose of the software (studying thermal storage) but not the functionality provided by the software. A brief description of the uses of the software in studying thermal storage should be added.
[x] The statement of need describes the intended uses and intended users of the software, but not the relation to other work. Is there other software used by researchers for similar purposes? Are there relevant publications of related scientific/engineering work that should be referenced to provide context?
[x] State of the field: Not adequately addressed, can be resolved by answering the questions above in the paper.
[x] Quality of writing: There is no problem with the quality of writing. However, the second figure should be referenced/described in the text and/or a caption should be provided so that the reader understands the significance.

The current references are good, but more may need to be added in resolving these points.

jakobhaervig commented 3 months ago

All of the above is addressed in https://github.com/OpenTerrace/openterrace-python/commit/28f25c7f9466655a7c95dea5f8601da89e0c21f7. Can't find any open-source frameworks like OpenTerrace for thermal energy storage systems. Instead I added a small overview of relevant models from literature.

baperry2 commented 3 months ago

Great, I think this wraps everything up for my review.

OpenTerrace / openterrace-python