OpenThaiGPT / openthaigpt-pretraining

Apache License 2.0
21 stars 10 forks source link

Add crawl data for top stories #253

Closed nattjn closed 1 year ago

nattjn commented 1 year ago

Why this PR

Why we need this PR? This PR if for crawling data from mfa/media center/top stories

Changes

Add data for crawling news' titles dates and details

Related Issues

Close #

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (c441682) 94.95% compared to head (69ce172) 94.95%.

:exclamation: Current head 69ce172 differs from pull request most recent head 9ca1cee. Consider uploading reports for the commit 9ca1cee to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #253 +/- ## ======================================= Coverage 94.95% 94.95% ======================================= Files 12 12 Lines 337 337 ======================================= Hits 320 320 Misses 17 17 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `94.95% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenThaiGPT#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

boat1603 commented 1 year ago

I think your PR has many changes (1 PR should less than 200 change excluding tests). If you want to add the new feature please open in another PR.