OpenThermal / libseek-thermal

SEEK thermal compact camera driver supporting the thermal Compact, thermal CompactXR and and thermal CompactPRO
MIT License
293 stars 100 forks source link

Add support for streaming to v4l2 #42

Closed Bostwickenator closed 4 years ago

Bostwickenator commented 4 years ago

I've added this functionality directly into the viewer example. I could however factor this out to a separate file if that helps to keep these examples easier to understand. While technically this should be able to stream to any v4l2 output I've only tested it with v4l2loopback.

The second colorspace conversion and use of RGB for v4l2 output is chosen due to extremely narrow color space support in Chromium. I think a bunch of people might be interested in using this to stream IR to video chat applications.

crabdancing commented 4 years ago

I just tried this and it works awesome. Why isn't this merged yet?

Bostwickenator commented 4 years ago

Happy to make any changes you need to get this merged @maartenvds

maartenvds commented 4 years ago

Hi there,

I'm currently not maintaining this repo anymore since I don't own a seek cam anymore (this way I cannot test any new features). Feel free to clone this repo and continue developing the library.

Kind regards

Maarten

Bostwickenator commented 4 years ago

@maartenvds Firstly let me say thanks for all the work you put into this. Would you consider transferring the repo to an organization so can keep development centralized? https://docs.github.com/en/enterprise/2.14/user/articles/transferring-a-repository#transferring-a-repository-owned-by-your-personal-account

crabdancing commented 4 years ago

I second @Bostwickenator. Also, I'd totally be willing to help maintain the source, if you need some volunteers. I already am maintaining the Arch Linux AUR package. :)

maartenvds commented 4 years ago

@Bostwickenator I appreciate your proposal to transfer the ownership. I would love to see the open source community continue developing this code base, so the only request I have is that it maintains open source under MIT license or some other similar permissive software license. And please mention the current copyright ownership in an acknowledgement if you will. Can you tell me about what 'organization' you want me to transfer it too? @alxpettit Thanks for jumping this train!

Bostwickenator commented 4 years ago

Sorry to be unclear I meant creating a new free org https://github.com/organizations/plan and transferring this project into that then adding say @alxpettit and I as contributors so we can manage the repo. Name wise the org could just be libseek.

maartenvds commented 4 years ago

@Bostwickenator Maybe its better that you create the org since a contact e-mail for the org is required. Then later I can transfer this repo to that org. Otherwise I need to somehow change the contact e-mail afterwards too.

Bostwickenator commented 4 years ago

Fair call! https://github.com/OpenThermal is setup, you should see an invite email soon if you haven't already.

maartenvds commented 4 years ago

@Bostwickenator It's done! Happy to transfer the steering wheel :-)

crabdancing commented 4 years ago

Awesome! @Bostwickenator you think this is ready to merge?

crabdancing commented 4 years ago

I'm in the OpenThermal org now, but I have read-only access still.