search

OpenThermal / libseek-thermal

SEEK thermal compact camera driver supporting the thermal Compact, thermal CompactXR and and thermal CompactPRO
MIT License
294 stars 100 forks source link

Request size per camera #52

Closed Bostwickenator closed 4 years ago

Bostwickenator commented 4 years ago

Set the lib usb request size to the maximum data that the camera returns. This appears to differ between different versions of the camera.

Bostwickenator commented 4 years ago

@alxpettit Hi do you have the Compact Pro or the Compact? I need someone to test this on the Compact as mine died (an unrelated death)

crabdancing commented 4 years ago

@Bostwickenator

I don't think it's a Pro. lsusb output is simply 289d:0010 Seek Thermal, Inc. PIR206 Thermal Camera [Seek Compact].

Edit: my patch for seek_viewer.cpp isn't in your branch, so it's not compiling on Arch Linux. Could you merge the patch sometime please? :P

Edit 2: for now I just fixed the CV4 compatibility issue by hand, and it seems to work fine. It was working fine for me before, though. Sorry about not having a Pro to test with. :/

Bostwickenator commented 4 years ago

Oh your patch was merged into the mainline a while back. I'm not sure why it wasn't in this MR. Regardless I'll make sure that sticks this time. I have the Pro and I tested with that if you tested with the regular Compact we have the coverage we need, thanks!!

Bostwickenator commented 4 years ago

Just to verify https://github.com/OpenThermal/libseek-thermal/pull/46 the totality of your OpenCV4 fix or did I miss something? I'm compiling against 2 and 3 so I could have missed something specific to 4.

crabdancing commented 4 years ago

@Bostwickenator yup that's all it is! :)

Edit: oooh, I see now. I was in the wrong branch. >.< Aaaagh. Sorry about that!

Edit 2: Okay, stashed, checkout, and clean recompile. Code in libusb_request_size works fine. And there's no CV4 issue. I think we're ready to merge! :D