Open vade opened 9 months ago
If we use our custom layer instructions in Beta 1 (currently commented out) - we get a video composition validation error with some sample media from Davinci Resolve, which has incredibly tiny taps likely due to numerical precision issues from converting RationalTime
to CMTime
:
See this thread on OTIO TSC Slack
(lldb) po timeRange.start.seconds
18.977291665
(lldb) po timeRange.end.seconds
18.977291666
We ideally want to find some lowest common denominators for our time conversion
Some observations so far
23.976
for example are typically represented as something like24000/1001
rates in CMTime23976
- which is fine, until we hit values very large72.1239898271647162
which shows up some times (seeRationalTime.fromSeconds()
for example)minFrameDuration
to renormalize times to avoid rounding issuesminFrameDuration
has wonky valuesIn short, our timing conversion isnt perfect
Things to try
naturalTimeScale
is a better replacement forminFrameDuration
to help with the best units for CMTime denominators.