OpenTimelineIO / OpenTimelineIO-AVFoundation

Conversion and Compatibility between OpenTimelineIO objects and their CoreMedia and AVFoundation counterparts
Apache License 2.0
22 stars 2 forks source link

Avoiding large decimal places / int overflow for CMTime <-> RationalTime conversion #4

Open vade opened 9 months ago

vade commented 9 months ago

We ideally want to find some lowest common denominators for our time conversion

Some observations so far

In short, our timing conversion isnt perfect

Things to try

vade commented 1 month ago

If we use our custom layer instructions in Beta 1 (currently commented out) - we get a video composition validation error with some sample media from Davinci Resolve, which has incredibly tiny taps likely due to numerical precision issues from converting RationalTime to CMTime :

See this thread on OTIO TSC Slack

(lldb) po timeRange.start.seconds
18.977291665
(lldb) po timeRange.end.seconds
18.977291666