Fixes for building on windows

OpenTimelineIO / OpenTimelineIO-C-Bindings

C bindings for the OpenTimelineIO Library (http://opentimeline.io)

http://opentimeline.io

Apache License 2.0

11 stars 7 forks source link

Fixes for building on windows #47

Closed BadSingleton closed 1 year ago

BadSingleton commented 1 year ago

Don't link to pthread on windows

Define a symbol instead of an int, MVSC can't see it as a constant (and gives an error).

linux-foundation-easycla[bot] commented 1 year ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: BadSingleton / name: Félix Bourbonnais (bcdf0b6d75edc31a8133c969f7f0b4acec829524)

meshula commented 1 year ago

Thanks for spotting those issues!

BadSingleton commented 1 year ago

Sorry, it's going to take a while. Legal got back to us and the person that can sign the CLA is currently on holiday.

BadSingleton commented 1 year ago

@meshula CLA is now signed!

meshula commented 1 year ago

Thanks!

BadSingleton commented 1 year ago

I can repro the same CI failure on the main branch, using Ubuntu 22.04 (which looks like to be ubuntu-latest according to github), but everything is fine on Ubuntu 20.04 (and also builds fine on win10 and macos 10.15 on our side).

meshula commented 1 year ago

The build failure is clearly unrelated. I'm inclined to land it.

If you have repro, are you able to tell what the issue is? Does the OTIO_API macro need some help?

BadSingleton commented 1 year ago

Sorry, I have no idea how to fix it nor to tell what exactly the problem is (other than obviously being a linkage issue)

meshula commented 1 year ago

Ok, cool. I just double checked, the CI has been broken for nearly a year, this isn't by any means a new issue.