OpenTimelineIO / otio-aaf-adapter

OpenTimelineIO Advanced Authoring Format (AAF) Adapter
Apache License 2.0
18 stars 7 forks source link

Remove leftover Python 2 references #19

Closed timlehr closed 1 year ago

timlehr commented 1 year ago

Summarize your change.

Removing some leftover Python 2 references in setup.py

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (1812f06) 90.15% compared to head (5e6ce71) 90.15%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #19 +/- ## ======================================= Coverage 90.15% 90.15% ======================================= Files 3 3 Lines 1107 1107 ======================================= Hits 998 998 Misses 109 109 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `90.15% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenTimelineIO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

timlehr commented 1 year ago

@apetrynet Not sure about the new Python versions. Which one do we support officially? CI seems to run 3.7-3.10

apetrynet commented 1 year ago

I don't know ATM. But adding the ones run in the ci should suffice. At least it's 1 to 1

timlehr commented 1 year ago

I think those are all present already.

apetrynet commented 1 year ago

Ah, sorry I was unclear. I meant in the versions listed in setup.py

timlehr commented 1 year ago

3.7 - 3.10 are already listed: https://github.com/OpenTimelineIO/otio-aaf-adapter/pull/19/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R54-R58

apetrynet commented 1 year ago

Sorry, @timlehr I should have expanded the diff 🤦‍♂️