Closed markreidvfx closed 9 months ago
Attention: 5 lines
in your changes are missing coverage. Please review.
Comparison is base (
72a811f
) 90.15% compared to head (6140cc2
) 90.00%.
Files | Patch % | Lines |
---|---|---|
..._aaf_adapter/adapters/advanced_authoring_format.py | 76.19% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We're not sure why codecov is unhappy with this. Will explore in more detail...
I found the codecov settings. https://github.com/OpenTimelineIO/otio-aaf-adapter/pull/30 should make the codecov checks "informational" instead of blocking for now - we can adjust them more as we get used to them.
This pull request fixes few issues I've discovered with the adapter relating to markers and transitions.
Before:
After:
Reference:
There are 2 main issues happening here. The first big issue is marker positions are not stored with transition offsets. The fix is to attach the marker after the transition lengths have been corrected. This does move the
_fix_transitions
to happen sooner in the transcribe process but I haven't noticed any issues doing this and all the tests still pass.The second issue is markers that land on top of transitions are getting lost. This is because transition don't have a markers attr. The fix is to find and attach the marker to the clip underneath.
The added test verifies the marker timings exactly against the timings exported by Media Composer. Both the absolute offsets and relative to clip offsets.