search

OpenTimelineIO / otio-aaf-adapter

OpenTimelineIO Advanced Authoring Format (AAF) Adapter
Apache License 2.0
15 stars 6 forks source link

AAFWriter: added support for AAF user comments (#22) #23

Closed timlehr closed 3 months ago

timlehr commented 1 year ago

Fixes #22

Summarize your change.

I added support for translating user comments in the OTIO metadata onto the mob objects.

Reference associated tests.

test_aaf_adapter.py

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.24%. Comparing base (74298e1) to head (09682e6). Report is 5 commits behind head on main.

:exclamation: Current head 09682e6 differs from pull request most recent head d9c5c87. Consider uploading reports for the commit d9c5c87 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #23 +/- ## ========================================== + Coverage 90.12% 90.24% +0.12% ========================================== Files 3 3 Lines 1124 1138 +14 ========================================== + Hits 1013 1027 +14 Misses 111 111 ``` | [Flag](https://app.codecov.io/gh/OpenTimelineIO/otio-aaf-adapter/pull/23/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenTimelineIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OpenTimelineIO/otio-aaf-adapter/pull/23/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenTimelineIO) | `90.24% <100.00%> (+0.12%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenTimelineIO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

timlehr commented 4 months ago

@jminor @markreidvfx I changed the code to omit unsupported types of data in the comments with a warning. I also added some more test cases for unicode, lists, dicts and OTIO schemas.