OpenTracksApp / OpenTracks

OpenTracks is a sport tracking application that completely respects your privacy.

https://OpenTracksApp.com

Apache License 2.0

952 stars 184 forks source link

Setting to toggle distance/speed unit announcements #1899

Closed dm1cael closed 2 months ago

dm1cael commented 2 months ago

Describe the pull request This pull request should fix #1805, while creating the option to enable or disable this type of announcement.

Link to the the issue

1805

License agreement By opening this pull request, you are providing your contribution under the Apache License 2.0 (see LICENSE.md).

dennisguse commented 2 months ago

Looks good. Did you check that the tests are green?

dm1cael commented 2 months ago

They are.

dennisguse commented 2 months ago

I need to fix #1898 first and then merge your PR - somewhen next week :D

i guess you are fixing #1805, right? If so, can you add "Fixes #1805." as a 2nd line in the commit message (Github then connects the commit and the issue together).

dm1cael commented 2 months ago

Done. Good luck with #1898 :)

dennisguse commented 2 months ago

Looks good - will ship with the next release! Thanks :D