OpenTransitTools-BonePile / trimet-mod-pelias

TriMet MOD Pelias ... related to https://github.com/conveyal/trimet-mod-otp
1 stars 0 forks source link

Wrong Street Type #30

Open fpurcell opened 5 years ago

fpurcell commented 5 years ago

Ideally, Pelias would find records when someone misses on the direction or street type. As of now, I've got one example address that works fine with the wrong type, at least until you also add the city to the query.

Works with wrong type: https://ws-st.trimet.org/pelias/v1/search?text=4015%20N%20ALBINA%20ST

Doesn't work with wrong street type + city (and state): https://ws-st.trimet.org/pelias/v1/search?text=4015%20N%20ALBINA%20ST,%20Portland https://ws-st.trimet.org/pelias/v1/search?text=4015%20N%20ALBINA%20ST,%20Portland%20OR

orangejulius commented 5 years ago

This is interesting. There are several changes we've made recently that could cause the first query to start working (I don't believe it always did), and if that's the case, we should be able to adjust things so that all the queries you linked to will work the same.

I'll investigate further and get back to you.

missinglink commented 5 years ago

Unfortunately, this boils down again to a bad libpostal parse:

http://localhost:4400/parse?address=4015%20N%20ALBINA%20ave,%20portland

[
  {
    "label": "house_number",
    "value": "4015"
  },
  {
    "label": "road",
    "value": "n albina ave portland"
  }
]
http://localhost:4400/parse?address=4015%20N%20ALBINA%20st,%20portland

[
  {
    "label": "house_number",
    "value": "4015"
  },
  {
    "label": "road",
    "value": "n albina st"
  },
  {
    "label": "city",
    "value": "portland"
  }
]