search

OpenTransport / vocabulary

A vocabulary to describe transport systems
36 stars 9 forks source link

Add the concept of a `journey` #6

Closed jcassee closed 10 years ago

jcassee commented 10 years ago

There seems to be a noun missing for "bus 23 leaving Amsterdam Central station at 14:20".

(Adds a newline at the end of the file too, sorry!)

pietercolpaert commented 10 years ago

:+1: - can be merged what I'm concerned

Yet this raises the question for me what word to use for a collection of journey_patterns that comes out of a journey planner. A trip perhaps? Or is a trip better suited for what is journey in this pull request?

jcassee commented 10 years ago

We use the term trip to refer to the result of a planning call, and trip_leg to the segment of a journey that is used. So if we plan from stop_area Kerkehout, Wassenaar to stop_area Weteringplein, The Hague, the result is a trip containing a trip_leg from journey Bus 90 from Kerkehout 22:56 to The Hague Central Station and trip_leg Tram 16 from Central Station 23:17 to Weteringplein.

Does that sound like something we could add to the vocabulary?

Tristramg commented 10 years ago

Aww, indeed, how could we have missed that.

I would however prefer the term vehicle_journey that matches the transmodel definition http://sitp.transmodel.org/transmodel_v5_en/pages/7dd1ba873a7e0292.htm And it will avoid any confusion with a trip

pietercolpaert commented 10 years ago

I am as well in favour of using the transmodel definition. Can we adapt this commit towards that?

jcassee commented 10 years ago

Will do!

jcassee commented 10 years ago

I actually wanted to add commit f659f03dd63ce2e6bde0b6bf27b609721d8cebc4 to a new pull request but forgot to put it in its own branch. Do you want to discuss trips separately?

pietercolpaert commented 10 years ago

Is it possible to rebase your pull request so we can automatically merge it?

pietercolpaert commented 10 years ago

Merged manually