Prevent leading/trailing blanks in UDF choice values

RickMohr commented 9 years ago

This is more involved than trimming UDF names because choice definitions are buried in UDF objects' datatype JSON field and choice values are buried in Plot or Tree objects' udfs hstore.

The data migration:

for each UDF definition
- if it has type "choice"
- for each choice value
  - if it needs trimming
  - trim it
  - for all Trees or Plots having this choice value for this UDF
    - use the trimmed value
  - for all Audits having this choice value (old or new) for this UDF
    - use the trimmed value

The validator (udf._validate_single_datatype) must trim all choice values, and (if any changed) update datatype['choices'] and serialize and save datatype.

maurizi commented 9 years ago

Not as bad as it seems at first: We already wrote the code to update choice values https://github.com/OpenTreeMap/OTM2/blob/077be607964965fb4200e09d59acf3b046131724/opentreemap/treemap/udf.py#L319-L339

jwalgran commented 5 years ago

OpenTreeMap / otm-core

Prevent leading/trailing blanks in UDF choice values #1823