search

OpenTreeMap / otm-core

OpenTreeMap is a collaborative platform for crowdsourced tree inventory, ecosystem services calculations, urban forestry analysis, and community engagement.
www.opentreemap.org
Other
186 stars 88 forks source link

Importer: tree created if "Tree Present" is false but a tree column has a value #1859

Closed RickMohr closed 9 years ago

RickMohr commented 9 years ago

If the "Tree Present" column is false for a tree import row, presumably the intent is to create a planting site but not a tree. However if a tree column (e.g. "Diameter" or a custom tree field like "Tree: Owner") contains a value we create a tree anyway. I don't think we should.

andrewbt commented 9 years ago

I like that idea, but perhaps if we don't create a tree it would be good to notify the user through a message. "XX out of YY trees in this import were not created because their 'Tree Present' column was set to false."

I've had some confusing experiences with CartoDB imports not working this week and they didn't give me good error messages so this is just on my mind.

On Wed, Dec 10, 2014 at 3:55 PM, Rick Mohr notifications@github.com wrote:

If the "Tree Present" column is false for a tree import row, presumably the intent is to create a planting site but not a tree. However if a tree column (e.g. "Diameter" or a custom tree field like "Tree: Owner") contains a value we create a tree anyway. I don't think we should.

— Reply to this email directly or view it on GitHub https://github.com/OpenTreeMap/OTM2/issues/1859.

Andrew Thompson, Community Evangelist

Azavea | 340 N 12th St, Ste 402, Philadelphia, PA athompson@azavea.com | T 215.701.7689 | F 215.925.2663 Web azavea.com http://www.azavea.com/ | Blog azavea.com/blogs http://www.azavea.com/Blogs | Twitter @azavea http://twitter.com/azavea

Join our community! Google Groups: Cicero API http://www.azavea.com/products/cicero/community/user-community/ | OpenTreeMap https://groups.google.com/forum/?fromgroups#!forum/opentreemap-user | GeoTrellis https://groups.google.com/forum/?fromgroups#!forum/geotrellis-user | OpenDataCatalog https://groups.google.com/forum/?fromgroups#!forum/opendatacatalog-user

jwalgran commented 9 years ago

I agree that if we support a "Tree Present" field, it should act as an override. @andrewbt 's suggestion is a good one, but I don't immediately know where, in the importer UI, we would present this information.

RickMohr commented 9 years ago

What should we do if there's a "Tree Present" column but the value is blank for a row? 1) Assume "True" and create a tree 2) Assume "False" and don't create a tree (even if tree fields are present) 3) If tree fields are present, create a tree; otherwise, don't create a tree

Same question if there is no "Tree Present" column.

RickMohr commented 9 years ago

My votes: If there is no "Tree Present" column, (3). If the value is blank for a row, (3).

jwalgran commented 9 years ago

I agree. "Tree Present" is just an override, so if we don't have the column, or the column does not have a truth-ish value, then we should fall back to only creating a tree if we have other tree-related fields in the row.

dboyer commented 9 years ago

I agree with both of you.

RickMohr commented 9 years ago

Fixed by #1915