Store geocoded address in URL when searching and show on page load

OpenTreeMap / otm-core

OpenTreeMap is a collaborative platform for crowdsourced tree inventory, ecosystem services calculations, urban forestry analysis, and community engagement.

www.opentreemap.org

Other

186 stars 88 forks source link

Store geocoded address in URL when searching and show on page load #3203

Closed maurizi closed 7 years ago

maurizi commented 7 years ago

Adds a new a parameter to the URL which is set when there is a non-boundary value in the location typeahead.

On page load on the map page, if the a parameter is present in the URL and no boundary filter is present, we geocode the address and display a map pin (which will also recenter the map on the pin).

Connects to #1123

coveralls commented 7 years ago

Coverage remained the same at 83.788% when pulling 1b65bcf942b7dcc14a0875032840d504dcef7d7f on maurizi:store-geocode-address-in-url into c655bdd2ec8d3f4dbc9452f421011b8ddde142f2 on OpenTreeMap:develop.

jwalgran commented 7 years ago

I ran into a geocode issue when change the species search after loading the page with an a= param.

On the map page, search for an address.
Refresh the page. The address and red pin appear correctly.
Select a species

Expected: No error. The red pin stays on the map. Actual: "Location not found" toast. The red pin is removed from the map.

maurizi commented 7 years ago

I ran into a geocode issue when change the species search after loading the page with an a= param.

Fixed in https://github.com/OpenTreeMap/otm-core/pull/3203/commits/1b65bcf942b7dcc14a0875032840d504dcef7d7f

coveralls commented 7 years ago

Coverage decreased (-0.002%) to 83.786% when pulling 1966591e23fd294ebf2b993713fbe38069890b35 on maurizi:store-geocode-address-in-url into c655bdd2ec8d3f4dbc9452f421011b8ddde142f2 on OpenTreeMap:develop.