Add lookups to enable modeling scenarios with overridden species - Githubissues

OpenTreeMap / otm-core

OpenTreeMap is a collaborative platform for crowdsourced tree inventory, ecosystem services calculations, urban forestry analysis, and community engagement.

www.opentreemap.org

Other

186 stars 88 forks source link

Add lookups to enable modeling scenarios with overridden species #3215

Closed jwalgran closed 7 years ago

jwalgran commented 7 years ago

Instances that were migrated into the database have species rows that do not have an otm_code, which modeling scenarios depend on.

To resolve this we have:

Added class method to Species to try fetching a species and fall back to using an ITreeCodeOverride
Added a validation to prevent loading species into the scenario drop-down lists that cannot be matched to an instance species

PhillyTreeMap before

screen shot 2017-09-06 at 2 17 21 pm

PhillyTreeMap after

screen shot 2017-09-06 at 2 16 58 pm

Modified the scenario run view function to use the new species fetch method.

Testing

Create a modeling scenario on PhillyTreeMap and add a single tree for every species in the list. Verify that the "Calculate Scenario" button works.
Create a modeling scenario on PhillyTreeMap, add a distribution area, and add a distribution for every species in the list. Verify that the "Calculate Scenario" button works.

Connects to https://github.com/OpenTreeMap/otm-clients/issues/352

coveralls commented 7 years ago

Coverage decreased (-0.06%) to 83.85% when pulling 878484193eef0d4c5de9d94bd5dd269b93671c89 on jwalgran:feature/modeling-species-overrides into 7b3f08b490e83a9479e9db53568d84043902b462 on OpenTreeMap:develop.