Export values in the units specified on the units management page - Githubissues

OpenTreeMap / otm-core

OpenTreeMap is a collaborative platform for crowdsourced tree inventory, ecosystem services calculations, urban forestry analysis, and community engagement.

www.opentreemap.org

Other

186 stars 88 forks source link

Export values in the units specified on the units management page #3223

Closed jwalgran closed 6 years ago

jwalgran commented 6 years ago

NOTE: This PR is built on top of #3222. Only commit 7d66d4f is new

Overview

Prior to this PR exported data was always in the default English units.

I took advantage of the custom serializer support in django-queryset-csv to do the conversions.

Connects https://github.com/OpenTreeMap/otm-clients/issues/399

Testing Instructions

Setup

Create a new instance with the url name unit-export-test http://localhost:6060/create/
Add a tree with a diameter of 1 and choose the "Continue editing this tree" at the end of the add tree wizard http://localhost:6060/unit-export-test/map/?m=addTree
- Set Tree Height, Canopy Height, Planting Site Width, and Planting Site Height to 1. Save.
Enable exports by adding credit card info to the billing management page http://localhost:6060/unit-export-test/management/billing/
- Name on card: t
- Card number 4242424242424242
- CVC: 424
- Expiration Month: whatever
- Expiration Year: in the future
- Billing address: t
- City: t
- State: t
- Zip: t
- Click "Save" then "Charge my card and activate my tree map"

Test

Click "Explore Map" in the header
Click "Export Search Results".
- If a file is not downloaded after 10 seconds, try restarting celery vagrant ssh app -c "sudo service celery restart"
- Verify the 1 values in the CSV
- Go to the Units management page and change to metric units with more digits. Save. http://localhost:6060/unit-export-test/management/units/
- Planting Site Width: centimeters, 2 digits
- Planting Site Height: centimeters, 2 digits
- Tree Diameter: centimeters, 2 digits
- Tree Height: meters, 2 digits
- Canopy Height: meters, 2 digits
Click "Explore Map" in the header and click "Export Search Results".
Verify that the values in the CSV are now metric
- 1in = 2.54cm
- 1ft = 0.3048m

coveralls commented 6 years ago

Coverage increased (+0.03%) to 83.869% when pulling 7d66d4f3fba8ade8afc37a13e8ca1a738f51120e on jw/export-units-fix into 83e32dad3c420db3a94fade7d4fd4e017283023d on develop.