Upgrade jquery

[jwalgran]

https://jquery.com/upgrade-guide/3.0/

1.10.2 -> 1.12.4

Issues

• [x] deferred.pipe() is deprecated after adding a photo to a tree on the detail page and any other photo upload

  migrateWarn | @ | jquery-migrate.js:47
  -- | -- | --
    | deferred.pipe.promise.pipe | @ | jquery-migrate.js:705
    | data.process | @ | jquery.fileupload.js:604
    | (anonymous) | @ | uploadPanel.js:84
   [...truncated...]

  Fixed in a newer version of jquery.fileupload

1.12.4 -> 3.3.1

• [x] Register new user
• [x] Reset password
• [x] Recover username
• [ ] User Profile
  • [x] Upload profile photo
  • [x] Edit user info
  • [x] Maps listed on user profile
  • [x] Favorites listed on user profile
  • [x] Edits listed on user profile
• [x] Create a new map
• [x] Add a tree
  • [x] Include a species during add process
  • [x] Include a diameter during add process
  • [x] Add as planting site - no diameter/species/tree height
  • [x] Finish adding tree
    • [x] Select "Add another tree with these details"
      • [x] Move dot
      • [x] Add the tree
    • [x] Select "Add another tree with new details"
      • [x] Move dot
      • [x] Add species and diameter
      • [x] Add the tree
    • [x] Select "Continue editing tree"
      • [x] Automatically go to tree detail page
      • [x] Change data field, save, and see updated data
    • [x] Select "I'm Done"
      • [x] Return to map page with add process closed
• [x] See correct ecobenefits
  • [x] Total eco
  • [x] Single tree in map sidebar
  • [x] Single tree on tree detail page
  • [x] Eco counts on TreeMapLA
  • [x] Plot count correct for which trees should contribute benefits
• [ ] Tree detail page
  • [x] Edit a field
  • [x] Edit a custom field
  • [x] Move location
    • [x] Location updates
    • [x] Google Street View updates
  • [x] Recent edits update correctly
  • [x] Percent complete is correct
  • [x] Upload photo
    • [x] Upload one photo
    • [x] Upload second photo
    • [x] Use slideshow feature
  • [x] Comment
    • [x] Leave a comment
    • [x] Reply to a comment
    • [x] Flag a comment
  • [x] Sharing
    • [x] Share photo on Facebook
    • [x] Share photo on Twitter
    • [x] Share photo on Google+
    • [x] Share photo on Pinterest
    • [x] Share tree detail page on Facebook
    • [x] Share tree detail page on Twitter
    • [x] Share tree detail page on Google+
    • [ ] Cannot share detail page while in trial mode
  • [ ] Delete
    • [x] Can delete tree
    • [ ] Can delete photo you uploaded
    • [x] Cannot delete photo uploaded by another user
• [x] Planting site detail page
  • [x] Edit a data field
  • [x] Edit a custom data field
  • [x] Move location
    • [x] Location updates
    • [x] Google Street View updates
  • [x] Upload photo
    • [x] Upload second photo
    • [x] Use slideshow feature
  • [x] Delete
    • [x] Can delete planting site
• [x] Quick Edit
  • [x] Edit species
  • [x] Edit diameter
  • [x] Edit tree height
  • [x] Move location
• [ ] Exports
  • [x] Species
  • [x] Users as CSV when map is public
  • [x] Users as JSON when map is public
  • [x] Users as CSV or JSON when map isn't public
  • [x] Search results
  • [x] Full set of trees (no search parameters in place)
• [ ] Search
  • [x] Search species
  • [x] Search address
  • [x] Search zip code
  • [x] Search from tree detail page returns to map page
  • [x] Reset button clears search
  • [x] Search by user-drawn polygon
  • [ ] Advanced search
    • [ ] Search last updated
    • [ ] Turn off tree display filter
    • [ ] Turn off planting site display filter
    • [ ] Search diameter
    • [ ] Search custom ID
    • [ ] Search date planted
    • [ ] Search missing species
    • [ ] Search missing diameter
    • [ ] Search missing photos
    • [ ] Custom advanced search
      • [ ] Add custom tree filter
      • [ ] Rearrange order of tree filters
      • [ ] Search by custom tree filter
      • [ ] Add custom planting site filter
      • [ ] Rearrange order of planting site filters
      • [ ] Search by custom planting site filter
      • [ ] Add missing data filter
      • [ ] Rearrange missing data filters
      • [ ] Search by missing data filter
• [ ] Custom fields
  • [x] Create custom field for tree
  • [x] Set custom field value on a tree detail page
  • [ ] Create custom field for planting site
  • [ ] Set custom field value on a planting site detail page
  • [x] Create multi-choice field
  • [x] Set multi-choice field value on a detail page
• [ ] External link
  • [x] Enable external link
  • [x] View external link on detail page
• [ ] Stewardship
  • [ ] Existing stewardship values
    • [x] Rename existing stewardship value for tree
    • [x] Delete existing stewardship value for a tree
    • [x] Add existing stewardship value to a tree detail page
    • [ ] Rename existing stewardship value for planting site
    • [ ] Delete existing stewardship value for a planting site
    • [ ] Add existing stewardship value to a planting site detail page
  • [ ] Custom stewardship
    • [x] Create custom stewardship value for tree
    • [x] Add custom stewardship value to a tree
    • [ ] Create custom stewardship value for planting site
    • [ ] Add custom stewardship value to a planting site
  • [ ] Search
    • [x] Search existing stewardship value for tree
    • [x] Search custom stewardship value for tree
    • [ ] Search existing stewardship value for planting site
    • [ ] Search custom stewardship value for planting site
• [ ] Importer
  • [x] Import tree inventory
  • [x] Import species list
• [ ] Management pages
  • [ ] Basic Info
    • [x] Set contact email
    • [ ] Set Tree ID
    • [ ] Set map to publicly visible
  • [ ] Branding
    • [x] Upload logo
    • [x] Set primary and secondary colors
  • [ ] Users
    • [x] Add user to tree map via email
    • [x] Added user can login and has public permissions
    • [x] Change user permissions for added user
    • [ ] Give user management access
  • [ ] Roles
    • [x] Create new role
    • [x] Edit role permissions
    • [ ] Prevent a role from adding trees or planting sites
    • [ ] Confirm role cannot add new tree or planting site
    • [ ] Role permissions accurately reflected in editing and viewing privileges available to user
  • [x] Ecosystem Benefits
    • [x] Change currency symbol
    • [x] New currency symbol visible on map and detail pages
    • [x] Change value
    • [x] Ecobenefit totals change due to new value
  • [x] Units
    • [x] Change unit of measurement
    • [x] New unit of measurement visible on detail page
    • [x] Change number of decimal places
    • [x] New number of decimal places visible on detail page
  • [x] Comments
    • [x] Notification bubble updates with new comment
    • [x] Unflag comment
    • [x] Hide comment
    • [x] Archive comment
    • [x] Notification bubble goes away after comments hidden or archived
    • [x] Batch change status of comments
    • [x] View hidden comments
    • [x] View archived comments
    • [x] Click through to detail page
    • [x] Export comments
  • [ ] Photos
    • [x] Notification bubble updates with new photo
    • [x] Delete photo
    • [x] Archive photo
    • [x] Notification bubble goes away after photos archived or deleted
    • [ ] Batch change status of photos
    • [x] View archived photos
    • [x] Click through to detail page
• [ ] Green Infrastructure
  • [x] Activate GSI resource
  • [x] Rename GSI resource
  • [x] Add GSI resource
    • [x] Move dots to draw a polygon
    • [x] Select add another resource when completing the GSI
    • [x] Select continue editing when completing the GSI
    • [x] Area of polygonal GSI appears in right sidebar
  • [x] GSI detail page
    • [x] Upload photo
    • [x] Edit data field
    • [x] Move location
    • [x] Street view updates when location moved
    • [x] Leave a comment
    • [x] Leave a stewardship action
  • [ ] Ecobenefits
    • [x] Enable ecobenefits for a resource
    • [x] Add annual rainfall
    • [x] View ecobenefits on detail page for a resource
    • [x] Edit runoff coefficent
    • [ ] View changed ecobenefits on detail page based on new runoff coefficient
    • [x] View ecobenefits in right sidebar on map page
  • [ ] Units
    • [x] Change unit for annual rainfall
    • [x] Change number of decimal places for annual rainfall
    • [ ] View changes on detail page
    • [ ] Change unit for drainage area
    • [ ] Change number of decimal places for drainage area
    • [ ] View changes on detail page
  • [ ] Search
    • [x] Search GSI stewardship
    • [x] Add GSI search filter
    • [x] Change order of GSI search filters
    • [x] Search GSI custom field
    • [x] Add missing GSI data filter
    • [x] Search missing GSI data
• [ ] Super Admin
  • [ ] Tree maps
    • [ ] Change number of maps per page
    • [ ] Filter maps by column headers
    • [ ] Filter maps by non-Azavea users
    • [ ] Edit expiration date for map
    • [ ] Edit tree limit
    • [ ] Add or remove module
    • [ ] Export maps
    • [ ] Changes logged in updates section
    • [ ] Set i-Tree region
    • [ ] Force suspension
    • [ ] Change map boundaries
• [ ] Modeling and Prioritization
  • [x] General
    • [x] Add module and view Plan link in header
    • [x] Create new plan with title and description
    • [x] Change status of plan to public
    • [x] Public user can view plan
    • [x] Delete plan
  • [ ] Priority Layers
    • [ ] Load priority layers template
    • [ ] Switch low/high range
    • [ ] Change weighting level
    • [ ] Add and remove layers and confirm map updates
    • [ ] Load saved priority layers
    • [ ] Saved layers reflect layer, zoom level, and masks
    • [ ] Mask by land use
    • [ ] Mask by zip code
    • [ ] Change percent of top areas visible
    • [ ] Change transparency level
    • [ ] Display OpenTreeMap tree dots
  • [x] Scenarios
    • [x] Add individual tree
    • [x] Set species and diameter for individual tree
    • [x] Draw distribution area
    • [x] Select geographic area as distribution area
    • [x] Set species and diameter for trees in distribution area
    • [x] Set annual mortality rate
    • [x] Set annual replanting rate
    • [x] Click calculate scenario and view scenario results
    • [x] Change results to view as currency
    • [x] Close results and change annual mortality rate
    • [x] Calculate scenario and view results that are different than first calculation
    • [x] Customize mortality by species and diameter
    • [x] View updated scenario results
    • [x] Export growth CSV
    • [x] Export eco CSV
• [x] Responsive Design
  • [x] Add tree
  • [x] Upload image
  • [x] Edit tree
  • [x] Search by address
  • [x] Use advanced search
  • [x] View ecobenefits
• [ ] Mobile Apps
  • [ ] Android
    • [ ] Create account
    • [ ] Add empty planting site
    • [ ] Edit planting site details
    • [ ] Add planting site stewardship item
    • [ ] Add tree
    • [ ] Add tree photo
    • [ ] Edit tree details
    • [ ] Add tree stewardship item
    • [ ] View ecosystem benefits
    • [ ] Search by location
    • [ ] Search by species
    • [ ] Search by other advanced search filter
  • [ ] iOS
    • [ ] Create account
    • [ ] Add empty planting site
    • [ ] Edit planting site details
    • [ ] Add planting site stewardship item
    • [ ] Add tree
    • [ ] Add tree photo
    • [ ] Edit tree details
    • [ ] Add tree stewardship item
    • [ ] View ecosystem benefits
    • [ ] Search by location
    • [ ] Search by species
    • [ ] Search by other advanced search filter

Deprecations

These items are reported by jquery-migrate in external libraries. The methods still exist in jquery 3.3.1 so we are opting to not try and update the otherwise working external libraries. In the case of typeahead, there is not a maintaned version that avoids these deprecated methods.

• JQMIGRATE: jQuery.expr[":"] is now jQuery.expr.pseudos
• JQMIGRATE: jQuery.fn.toggleClass( [ boolean ] ) is deprecated
• JQMIGRATE: jQuery.parseJSON is deprecated; use JSON.parse
• JQMIGRATE: jQuery.fn.unbind() is deprecated

Issues

• [x] JQMIGRATE: jQuery.fn.bind() is deprecated in otmTypeahead.js.
• [x] Administrator cannot delete photos. "Yes" button on the delete modal is greyed out.
• [x] JQMIGRATE: jQuery.fn.removeAttr no longer sets boolean properties in udfs.js

[jwalgran]

As recommend, I started by upgrading to the latest 1.x version of jQuery and adding the 1.x version of jquery-migrate. I will add issues logged by jquery-migrate as checklist items in the issue description.