Incorporate the basemap provider into selected basemap storage

OpenTreeMap / otm-core

OpenTreeMap is a collaborative platform for crowdsourced tree inventory, ecosystem services calculations, urban forestry analysis, and community engagement.

www.opentreemap.org

Other

186 stars 88 forks source link

Incorporate the basemap provider into selected basemap storage #3244

Closed jwalgran closed 6 years ago

jwalgran commented 6 years ago

Overview

OTM supports multiple basemap providers, each with different basemap names. When we store the selected basemap, we need to namespace that selection under the provider name.

Connects https://github.com/OpenTreeMap/otm-cloud/issues/438

Testing Instructions

Browse the map page of an existing instance
Change the basemap to satellite
Refresh the page and verify that the basemap change persists
Browse /create and work through the instance creation wizard
Verify that the Bing basemap correctly appears on the 3rd page of the create wizard

coveralls commented 6 years ago

Coverage remained the same at 83.867% when pulling 958553a6deb4ed452248abfa2ce558d9c4b9ee13 on jcw/fix-basemap-restore into ba2edfe210cac572455810b8774807b265fd6458 on release/2.21.0.

jwalgran commented 6 years ago

Thanks for taking a look. We will give it a final QA on staging.

dboyer commented 6 years ago

@jwalgran I finally had a chance to check this and I was able to change the basemap on an existing map and then create a new map. If it matters, it looks like the basemap change impacts any map you have open in your browser. I had an old map set to satellite layer in one tab and my newly created map set to streets layer in another tab. When I refreshed the tab with the old map, it switched to the streets layer.