Allow a hidden Tree ID field to be shown

jwalgran commented 5 years ago

Overview

The management page was allowing the Tree ID field to be hidden, but was not rendering the option in the hidden field list so that it could be shown again. We have corrected the _should_show_field predicate function and corrected the model argument passed to it so that the Tree ID field is correctly shown in the disabled field list.

Connects #3264 Depends on https://github.com/OpenTreeMap/otm-cloud/pull/467

Demo

2018-12-21 14 48 40

Testing Instructions

Create an instance named tree-id-show-and-hide-test
Browse http://localhost:6060/tree-id-show-and-hide-test/management/field-configuration/
Click "Edit"
Uncheck "ID" in the "Tree" section.
Click "Save"
Refresh the page and click "Edit". Verify that "ID" appears in the "Tree" section.
Check "ID" and click "Save"
Refresh the page and verify that "ID" appears in the "Tree" section.

coveralls commented 5 years ago

Coverage remained the same at 83.796% when pulling a2e3cdae25726152757fd15771cd3df5129a3b8a on jcw/hidden-tree-id-can-be-shown into dc0428c468707a38ea41176204b527b1832e9a8d on hotfix/2.21.5.

jwalgran commented 5 years ago

Thanks.

OpenTreeMap / otm-core