search

OpenTreeMap / otm-core

OpenTreeMap is a collaborative platform for crowdsourced tree inventory, ecosystem services calculations, urban forestry analysis, and community engagement.
www.opentreemap.org
Other
186 stars 88 forks source link

Encode the searchExtent param when making ESRI geocode request #3273

Closed jwalgran closed 5 years ago

jwalgran commented 5 years ago

Requests with unescaped curly brace characters started returning 400s.

Connects https://github.com/OpenTreeMap/otm-cloud/issues/476

Depends on https://github.com/OpenTreeMap/otm-cloud/pull/477 Depends on https://github.com/OpenTreeMap/otm-website/pull/190

jwalgran commented 5 years ago

I verified that this resolves geocoding issues in development. Merging this to expedite testing and release of the hotfix.

jwalgran commented 5 years ago

Waiting until after the pull request build is successful before merging.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 83.782% when pulling a34ddbbb336872b1c918525f27836d79eeefea76 on jcw/encode-geocode-param into 4cd94985bc1a7ffdc38d2ce78faa696eb287db0f on hotfix/2.22.1.

jwalgran commented 5 years ago

@azavea-bot Rebuild

jwalgran commented 5 years ago

@azavea-bot Rebuild