OpenTreeMap / otm-core

OpenTreeMap is a collaborative platform for crowdsourced tree inventory, ecosystem services calculations, urban forestry analysis, and community engagement.
www.opentreemap.org
Other
186 stars 88 forks source link

Fix tests in several apps #3291

Closed fungjj92 closed 4 years ago

fungjj92 commented 4 years ago

Overview

This PR fixes all remaining failing tests in the api, otm1_migrator, map_features, stormwater, cloud_management apps.

The type of fixes continued to be related to binary & unicode encoding of strings or data.

This leaves treemap and importer to go 🎉

Ran 1121 tests in 322.639s

FAILED (failures=20, errors=32, skipped=23)

Notes

The commit descriptions are less noticeably less robust than their predecessors on parent branches. This is because these fixes are not novel in the type of problem they are fixing. I am inclined to squash some of these commits before merging the parent branch jf/fix-tests-2to3 into the python3 feature branch.

Testing

Run tests for all apps that should be fixed up to this point ./scripts/manage.sh test stormwater otm1_migrator api map_features cloud_management exporter

Inversely, running ./scripts/manage.sh test should return the same output as in this PR's overview.