search

OpenTreeOfLife / germinator

miscellaneous scripts and data for concerns that span more than one of the Open Tree code repositories: integration tests, system statistics, etc.
BSD 2-Clause "Simplified" License
21 stars 7 forks source link

Remove all 'translate' logic from run_tests.sh #118

Closed jar398 closed 7 years ago

jar398 commented 7 years ago

The host:translate parameter defaults to false, as it should. It ought to be overridable on either the command line or in a config file, but config file override doesn't work because it is special-cased in run_tests.sh. I'm pretty sure that simply removing these three lines should make it all work, but I suppose this belief ought to be tested.

if [[ ! "$config_specs" =~ "host:allowwrite=" ]]; then
    config_specs="$first_config_spec $* host:allowwrite=false"
fi
mtholder commented 7 years ago

these lines require the that the allowwrite option be specified by the command line (rather than conf file). I, personally, do not care if that behavior is retained or not.

But I'm not sure how this interacts with host:translate Is there some interaction between host:allowwrite and host:translate? If so, is that documented?

jar398 commented 7 years ago

I think this has been fixed. In any case, there is no longer any special treatment of host:translation in run_tests.sh in this repo, so I will close.