Open mtholder opened 7 years ago
Couple of questions:
x
be mrcaB1C2
(or other combination of descendant taxa)?B_ott6
or C_ott9
as labels on the synthetic tree (i.e. are these 'good' taxon names that happen to have the incertae sedis flag, vs having names like "unclassified blah")We could use the MRCA notation, but I think we still have to communicate to the user that things have changed and now it is possible for one node in the tree to match >1 ott definition. Or, at least it makes sense to me that we'd want to communicate that to users.
In answer to the second point: yes, I was thinking of both B_ott6
and C_ott9
as valid taxa, they just cannot be excluded from intruding on other taxa in the tree. So not tips labeled "unclassified blah".
@bredelings and I are working on the propinquity and otcetera changes needed to support treating incertae sedis taxa correctly. One wrinkle is that the same node can be identified by multiple OTT IDs:
So if the taxonomy is:
with asterisks denoting incertae sedis taxa, and the synth tree is:
then the node
x
could be labeledB_ott6
orC_ott9
. We may not have any such cases in a synthetic tree, but we should probably figure out what we are going to do for when they start showing up.It would be easy to list these synonomies in the annotations file produced by propinquity. It is less clear how they would be dealt with in web services. In particular, several tree-of-life calls return an ott ID.
Should that field be expanded to be an array of integers, or should we just pick one (e.g. the one with the lowest number) and list the synonyms in an additional field?
The larger issue is that any naming scheme in the face of incertae sedis taxa requires some definition of what the OTT IDs mean. My gut instinct would be to say that: