search

OpenTreeOfLife / germinator

miscellaneous scripts and data for concerns that span more than one of the Open Tree code repositories: integration tests, system statistics, etc.
BSD 2-Clause "Simplified" License
21 stars 7 forks source link

Fix all inbound URLs to use our preferred hostname #141

Closed jimallman closed 5 years ago

jimallman commented 5 years ago

This captures all URLs that match our numbered aliases like ot23.opentreeoflife.org. Addresses OpenTreeOfLife/opentree#1178

We use a 301 (permanent) redirect, which should ultimately fix the bad URLs indexed by Google.

This fix has been tested on devtree, see the results for these URLs:

BAD: https://ot16.opentreeoflife.org/opentree/argus/opentree10.4@ott844192/Bacteria GOOD: https://devtree.opentreeoflife.org/opentree/argus/opentree10.4@ott844192/Bacteria

And compare to these URLs on tree (production):

BAD: https://ot43.opentreeoflife.org/opentree/argus/opentree10.4@ott844192/Bacteria GOOD: https://tree.opentreeoflife.org/opentree/argus/opentree10.4@ott844192/Bacteria

bredelings commented 5 years ago

Why is the no-daemonize stuff in here? is that still relevant? I thought that was mostly for old versions of ubuntu that didn't have daemonize available.

jimallman commented 5 years ago

Why is the no-daemonize stuff in here? is that still relevant?

Oh no! That shouldn't have been applied here... I originally made these changes on the no-daemonize branch, then stashed and applied them against master. I guess that somehow dragged those (unrelated) changes along for the ride... Sorry @bredelings, I'll figure out how to back them out.

UPDATE: OK, I added one more commit to revert 5e53ae5. Now the only changes in this PR are related to the intended 301 redirect.