Extra (or undocumented) returns values from /v3/tnrs/match_names

jimallman commented 8 years ago

Lots of extra fields in the response compared to the spec. I see includes_dubious_names in the main response body, plus a mix of old and new field names in the matches structure:

    "matches" : [ {
      "matched_node_id" : 2571416,
      "synonyms" : [ "Nectarinia fuelleborni", "Cinnyris mediocris fuelleborni", "Cinnyris fuelleborni" ],
      "flags" : [ ],
      "ott_id" : 4131373,
      "ot:ottTaxonName" : "Cinnyris fuelleborni",
      "search_string" : "nectarinia fuelleborni",
      "matched_name" : "Nectarinia fuelleborni",
      "is_synonym" : true,
      "score" : 1.0,
      "unique_name" : "Cinnyris fuelleborni",
      "ot:ottId" : 4131373,
      "is_deprecated" : false,
      "name" : "Cinnyris fuelleborni",
      "nomenclature_code" : "ICZN",
      "is_approximate_match" : false,
      "rank" : "",
      "is_dubious" : false
    } ]

josephwb commented 8 years ago

@jimallman This is tnrs, so not me.

jar398 commented 8 years ago

I'm in the middle of fixing the v3 tnrs API. Should be ready later today.

jimallman commented 8 years ago

Apologies to you both for my hasty (mis)assignment.

jar398 commented 8 years ago

@jimallman Please confirm expected v3 operation, and close this issue at your leisure.

On Fri, Mar 18, 2016 at 10:45 AM, Jim Allman notifications@github.com wrote:

Apologies to you both for my hasty (mis)assignment.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/OpenTreeOfLife/germinator/issues/58#issuecomment-198392397

kcranston commented 8 years ago

The results on test now match the spec and the docs. Closing.

OpenTreeOfLife / germinator

Extra (or undocumented) returns values from /v3/tnrs/match_names #58