search

OpenTreeOfLife / germinator

miscellaneous scripts and data for concerns that span more than one of the Open Tree code repositories: integration tests, system statistics, etc.
BSD 2-Clause "Simplified" License
21 stars 7 forks source link

mrca results must include a source_id_map #68

Closed jar398 closed 8 years ago

jar398 commented 8 years ago

In addition to mrca and optional nearest_taxon, the mrca method needs to return a source_id_map, since the node-blob will contain support/conflict properties.

(This is really minor, but we said we'd do all spec changes as issues.)

kcranston commented 8 years ago

It looks like this is done in the code. Docs are changed. Is there a test for this?

jar398 commented 8 years ago

There's a syntactic check. (no check to make sure it's the right source id map.)

On Thu, Mar 24, 2016 at 11:03 AM, Karen Cranston notifications@github.com wrote:

It looks like this is done in the code. Docs are changed. Is there a test for this?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/OpenTreeOfLife/germinator/issues/68#issuecomment-200875829