search

OpenTreeOfLife / opentree

Opentree browsing and curation web site. For overarching or cross-repo concerns, please see the 'germinator' repo.
http://tree.opentreeoflife.org/
BSD 2-Clause "Simplified" License
108 stars 26 forks source link

"Look up doi" button weirdness #1321

Open snacktavish opened 1 year ago

snacktavish commented 1 year ago

"Look up doi" button works fine on dev, but just links out to crossref on production. Maybe related to phylesystemapi update somehow?

snacktavish commented 1 year ago

Nevermind! I tried again and it worked fine.... ? I will leave open for a bit to see if I can make it happen again and track

jimallman commented 1 year ago

Copying this from Gitter chat:

Clicking the 'Look Up DOI...' button will fall back to CrossRef if the 'Publication reference' field is empty. Any visible text in this field should do the normal popup dance with matching DOIs.

In other words, this is expected (by me 😸) behavior unless there's text in the 'Publication reference' field. Would you liek to see a different response with there's no ref text, maybe a prompt in the site footer?

snacktavish commented 1 year ago

Ahhh! I wanted it to look up the reference text form the doi, and I thought it would do it. I know if there is text in the reference field you can correct it from the doi, but maybe you need to paste the DOI into reference field not the doi field first?

snacktavish commented 1 year ago

To further clarify - I had pasted in the DOI when I created the study, but for some reason it didn't autofill any text into the ref. I wanted it to try again on the auto fill - and if I pasted the DOI into the reference text field, it did fill in the whole reference. Can it do that if the DOI is just in the DOI field as well?

jimallman commented 1 year ago

I get what you're saying. It's a reasonable use case, if all I have is the DOI or I want to make sure the reference text is correct. And yes, I can certainly add the contents of the DOI field to the search-bait. The tricky scenario is if the starting ref-text and DOI somehow disagree... Should we always choose one field over the other? Or rely on the list of possible matches to settle things, since the results offered would hopefully reflect the contents of both fields... Yeah, that seems likely.

jimallman commented 1 year ago

@snacktavish The new behavior (submitting DOI field to CrossRef, along with the current reference text) is live now on devtree. Please give it a try and, if you like the change, maybe close this and merge the related PR.