search

OpenTreeOfLife / opentree

Opentree browsing and curation web site. For overarching or cross-repo concerns, please see the 'germinator' repo.
http://tree.opentreeoflife.org/
BSD 2-Clause "Simplified" License
108 stars 26 forks source link

Collections metadata confusion #1344

Open snacktavish opened 4 months ago

snacktavish commented 4 months ago

https://github.com/OpenTreeOfLife/collections-1/blob/master/collections-by-owner/snacktavish/aves.json#L178

For some reason several (but not all) studies in this collection have metadata about "ot:studyPublicationReferenc" as well as "ot:studyPublicationReference"

They are often both the same, but not always. I am confuse!


"ot:studyPublicationReferenc": "Hruska, J. P., Holmes, J., Oliveros, C., Shakya, S., Lavretsky, P., McCracken, K. G., Sheldon, F. H., & Moyle, R. G. (2023). Ultraconserved elements resolve the phylogeny and corroborate patterns of molecular rate variation in herons (Aves: Ardeidae). Ornithology. https://doi.org/10.1093/ornithology/ukad005\n",
"ot:studyPublicationReference": "No matching publication found for this DOI!",`
``

I put the issue here, but I don't_ actually know where it comes form... could be otindex.
jimallman commented 4 months ago

This is my fault! I had a typo in the Javascript for building and storing collections. The fix is referenced above, and has already been merged into branch staging.

NB - Existing collections in phylesystem might have redundant properties, so we'll need a batch operation to clean up and disambiguate some collections, esp. if there are different values for ot:studyPublicationReferenc and ot:studyPublicationReference. I've added the phylesystem batch operation label to this issue so it doesn't get lost.