search

OpenTreeOfLife / opentree

Opentree browsing and curation web site. For overarching or cross-repo concerns, please see the 'germinator' repo.
http://tree.opentreeoflife.org/
BSD 2-Clause "Simplified" License
111 stars 26 forks source link

Synonyms used in mapping should be visible to the user in some way #499

Open mtholder opened 10 years ago

mtholder commented 10 years ago

For example in commit, https://github.com/OpenTreeOfLife/phylesystem-1/commit/dfd9503d8706c33d814d253f0f455ef9c798b466

I modified 'Eriocran' to 'Eriocrania subpurpurella' then when I clicked the map, it resolved to "Dyseriocrania subpurpurella" in OTT.

That mapping is the correct. "Eriocrania subpurpurella" is a junior synonym (suppl. mat. of the paper confirms this).

But it would be nice if the user could see that the match was actually a perfect match, and the discrepancy is due to synonymy. The TNRS did not just make a "close enough" match of the text strings.

In this case it is not obvious because the valid name is only 3 letters off from the junior synonym. But (due to taxonomists tendencies to reuse Greek/Latin roots to generate very similar genus names, and the preservation of the specific epithet in most reclassifications) this sort of case won't be very rare.

*edited to clarify that the "suppl. mat." refers to info from the supplementary materials of the publication.

jimallman commented 9 years ago

@mtholder, I've tried to standardize the presentation (and tooltips) for single mapping results in the better-mapping-feedback branch. Here's a screenshot showing the new behavior and the synonym explanation as a tooltip:

screen shot 2014-12-31 at 2 12 07 am

The candidate mapping still needs to be approved using the old UI. Once it's been approved, the tooltip will disappear and we'll see the name in the familiar style:

screen shot 2014-12-31 at 2 15 08 am

Does this address the issue? Is a tooltip too obscure? Do you think it's OK to remove this explanation for approved mappings?

mtholder commented 9 years ago

@jimallman looks great to me. My (slight) preference would be that we would find a way to add the matched name (the junior synonym) to the nexson as an optional field. That would make it easier for people who are working with the corpus of NexSONs to understand what happened. But that is a minor concern. Perhaps we can discuss it on the next call, and make an issue for that feature if we decide that it is wise.

jimallman commented 9 years ago

Agreed, let's discuss and (if desired) make a separate issue for adding this to nexson. Keeping this open as a reminder to have that discussion. :grin: Maybe discuss on the opentree (or opentree-software) group?