Inconsistent labeling of 'ot:curatedType' in curation UI

OpenTreeOfLife / opentree

Opentree browsing and curation web site. For overarching or cross-repo concerns, please see the 'germinator' repo.

http://tree.opentreeoflife.org/

BSD 2-Clause "Simplified" License

107 stars 26 forks source link

Closed jimallman closed 9 years ago

jimallman commented 9 years ago

It looks like the curation UI is inconsistent in its labeling. Here are a tree's properties when we're editing:

screen shot 2015-01-19 at 9 34 46 am

...and here's the same tree when we're just viewing the study (note the label for this field!):

screen shot 2015-01-19 at 9 35 04 am

Which label is correct? See the related (ongoing) discussion in #552...

jar398 commented 9 years ago

'tree type' doesn't make sense as a field label. I vote for 'inference method'.

kcranston commented 9 years ago

I think 'inference type' and 'tree type' are two different concepts.

inference type = {maximum likelihood, maximum parsimony, bayesian, neighbour-joining}
tree type is less straightforward. This could be {gene tree, species tree, supertree} or {ML tree, consensus tree, MAP tree}

More discussion needed.

kcranston commented 9 years ago

Let's standardize this to inference method in the short term. Once we make the decisions needed for #570 we'll update this UI.

jimallman commented 9 years ago

Let's standardize this to inference method in the short term.

Agreed. This has been done (in both the trees list and tree popup) and merged to master.