search

OpenTreeOfLife / oti

indexing service for the OpenTreeOfLife nexson repository
Other
1 stars 0 forks source link

update pom to java 8 #44

Closed josephwb closed 9 years ago

josephwb commented 9 years ago

Possibly a solution to the current breakage (conflicting compile vs. runtime versions of java). :bowtie:

jar398 commented 9 years ago

Happy to incorporate this. But for the record, (a) the previous java version in the poms was 6, and java 6 wasn't even installed, so clearly nobody is taking this declaration seriously. (unless it reflects a minimum requirement, in which case it ought to be harmless, or even beneficial.) (b) the error in question is supposed to arise when you run new .class files in an old JVM. We were by all evidence running a new JVM already, so the cause of the error is very mysterious, and not simple JVM version skew. (c) the error in question went away after reloading the service, before this patch was made. So this PR wasn't necessary to fix OTI, and we don't know whether this PR had any effect at all.

On Thu, Sep 10, 2015 at 3:05 PM, Joseph W. Brown notifications@github.com wrote:

Possibly a solution to the current breakage (conflicting compile vs. runtime versions of java).

[image: :bowtie:]

You can view, comment on, or merge this pull request online at:

https://github.com/OpenTreeOfLife/oti/pull/44 Commit Summary

  • update pom to java 8

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/OpenTreeOfLife/oti/pull/44.

josephwb commented 9 years ago

Agreed; hence the "possibly" in the PR description above. Presumably (?) oti has been restarted numerous times since the latest update, so it seems inconceivable that a java incompatibility should emerge suddenly. Very confusing what was going on.