This is mainly cleaning and refactoring inspired by PyCharm's static checkers.
One notable change is a renaming of peyotl.collections to peyotl.collections_store to avoid clashes between the standard library collections when code within peyotl is being executed. This was not a serious issue, but was a minor annoyance. That change requires a simple change of imports in phylesystem-api (I'll submit a PR for that soon). I tested the phylesystem-api changes with the ws-tests on devapi. Manual creation of a collection there seems to work, but we are having an issue with deploy keys on collections-0 and devapi.
This was developed off of branch that generated https://github.com/OpenTreeOfLife/peyotl/pull/161 (so the change set will be smaller if that one is merged).
This is mainly cleaning and refactoring inspired by PyCharm's static checkers.
One notable change is a renaming of
peyotl.collectionstopeyotl.collections_storeto avoid clashes between the standard librarycollectionswhen code within peyotl is being executed. This was not a serious issue, but was a minor annoyance. That change requires a simple change of imports in phylesystem-api (I'll submit a PR for that soon). I tested the phylesystem-api changes with the ws-tests on devapi. Manual creation of a collection there seems to work, but we are having an issue with deploy keys on collections-0 and devapi.