search

OpenTreeOfLife / phylesystem-api

API access to Open Tree of Life treestore
BSD 2-Clause "Simplified" License
9 stars 5 forks source link

Update CrossRef API calls #223

Closed jimallman closed 5 years ago

jimallman commented 5 years ago

See background and related discussion in https://github.com/OpenTreeOfLife/opentree/issues/1193

This is tested and working now on devapi.

snacktavish commented 5 years ago

Is potentially interacting oddly with checking for duplicate doi. Didn't get a warning on creating study https://devtree.opentreeoflife.org/curator/study/view/tt_244, even though https://devtree.opentreeoflife.org/curator/study/view/tt_241 already existed.

Dup doi is recognized in tt_241, but not tt_244.

jimallman commented 5 years ago

@snacktavish I still have a few related updates to DOI lookup features elsewhere. Will make sure this is on my naughty list.

snacktavish commented 5 years ago

Was actually due to index lag from previous failed github webhooks. tt_244 was in the index, and tt_241 wasn't, which makes this behavior make sense! Changes in this branch not responsible.

snacktavish commented 5 years ago

Weird behavior was due to index lag. I poked it a bunch and everything seems good.

jimallman commented 5 years ago

OK, DOI lookup tool (in study editor) is now using the latest CrossRef APIs. It's a bit more tap-dancing, but seems to be working well even in cases where reference text has lots of funky Unicode. Tested and working on devtree.