OpenTreeOfLife / taxomachine

taxonomy graphdb
Other
7 stars 4 forks source link

'unclassified' should be treated same as incertae sedis #108

Closed jar398 closed 8 years ago

jar398 commented 9 years ago

See https://github.com/OpenTreeOfLife/feedback/issues/147

OTTFlag.java has UNCLASSIFIED ("unclassified", false), (and similarly for affiliated flags). That should be 'true', not 'false'.

hyanwong commented 8 years ago

Would be v. useful to me to get this fix in, given it seems a trivial one. Any ETA for this?

jar398 commented 8 years ago

https://github.com/OpenTreeOfLife/taxomachine/pull/110 We had trouble building the taxomachine database recently, but when Joseph did it it worked. I'll see if he's willing to help out again.

hyanwong commented 8 years ago

Great, thanks. Sorry to bug about it.

josephwb commented 8 years ago

I am doing so right now. Should be available later tonight (I'll post when it is deployed).

jar398 commented 8 years ago

@hyanwong sorry, we are experiencing technical difficulties, and it's not done yet. hang on.

josephwb commented 8 years ago

Things are deployed on dev, but there is a concern that the DB is smaller than before, so things may be broke.

jar398 commented 8 years ago

Deployed to production.