search

OpenTreeOfLife / taxomachine

taxonomy graphdb
Other
7 stars 4 forks source link

new name for contextQuery, and changes to contextQuery properties #60

Closed chinchliff closed 10 years ago

chinchliff commented 10 years ago

@jimallman,

I have a couple of (hopefully painless) requests for you. In this commit are a couple of consistency improvements for TNRS, which I would like to have propagated to devapi (at least) before the hackathon. Since we're working on this now, it seemed like as good a time as any.

  1. I am deprecating the name contextQueryForNames in favor of just contextQuery. The service will be identical, and will still be available under the old name, so nothing will break. But if you would please update your references to use the new name, that would be great!
  2. On a related note, I also deprecated autocompleteBoxQuery in favor of just autocompleteQuery a while ago, which should also be changed in various applications if it hasn't already.
  3. The results of the contextQuery need some tweaking (as we have discussed elsewhere). There will be some changes that won't affect anything now (but which will be useful later). However, I am also switching the two arguably most important existing properties over to their ot:X designations for consistency with other OT applications. They are:

matched_name -> ot:ottTaxonName matched_ott_id -> ot:ottId

These property changes will need to be matched by changes in clients or OTU mapping (and other uses of contextQuery, if they exist) will fail.

All the changes are in this pull request. Could you please make the required adjustments to the curator (and any other client apps under your control?) and then merge this into master so these will be reflected on devapi?

jimallman commented 10 years ago

OK. Matching changes in webapps are complete. Merging this now for a quick test.