search

OpenTreeOfLife / taxomachine

taxonomy graphdb
Other
7 stars 4 forks source link

API v2 taxonomy (merge me first) #65

Closed chinchliff closed 10 years ago

chinchliff commented 10 years ago

Version 2 of of the API for accessing taxonomy data outside the scope of TNRS.

This depends on the very minor pull request to ot-base at https://github.com/OpenTreeOfLife/ot-base/pull/6

chinchliff commented 10 years ago

@josephwb, @jar398, will you review?

chinchliff commented 10 years ago

Note, you can pretty much ignore the giant red walls from the Jade* stuff I removed (e.g. JadeNode, JadeTree, etc.), those were outdated versions of those classes. The correct Jade* classes are in the jade repo (and have been for well over a year now).

josephwb commented 10 years ago

I will look at this in the morning. JWB.

On 4 September 2014 17:30, Cody Hinchliff notifications@github.com wrote:

Note, you can pretty much ignore the giant red walls from the Jade* stuff I removed (e.g. JadeNode, JadeTree, etc.), those were outdated versions of those classes. The correct Jade* classes are in the jade repo (and have been for well over a year now).

— Reply to this email directly or view it on GitHub https://github.com/OpenTreeOfLife/taxomachine/pull/65#issuecomment-54548281 .

jar398 commented 10 years ago

Is this deployed to devapi? Are there tests I can review and run?

chinchliff commented 10 years ago

It is not deployed. The only tests that exist at the moment are curl calls.

On Friday, September 5, 2014, Jonathan A Rees notifications@github.com wrote:

Is this deployed to devapi? Are there tests I can review and run?

— Reply to this email directly or view it on GitHub https://github.com/OpenTreeOfLife/taxomachine/pull/65#issuecomment-54629592 .

jar398 commented 10 years ago

I would prefer not to merge unless there are tests that I can do.

I set a pretty low bar, so a text file in the repository containing the curl commands and some indication of what kind of result is expected, while not ideal, is fine for now.

Deployment to devapi would be required in order for me to run the tests.

Thanks

chinchliff commented 10 years ago

Can you give me an example of how to specify the branch to pull from when pushing to devapi?

jimallman commented 10 years ago

UPDATE: changed devtree to devapi below

Can you give me an example of how to specify the branch to pull from when pushing to devapi?

This is done in the server-config files in deployed-systems, using the opentree-branch command. For example, here we specify the Cavia branch for component opentree..

In this case, you'll want to modify this line in ot10.config like so:

opentree_branch taxomachine api_v2

... then call push.sh with this config file to deploy it to devapi.

chinchliff commented 10 years ago

Ok, there is a file at tests/test_taxonomy_v2.txt that includes curl calls and their expected output. You can try futzing with the calls to test different cases.