OpenTreeOfLife / treemachine

Source tree graph database
Other
16 stars 6 forks source link

node lica problem #164

Closed blackrim closed 9 years ago

blackrim commented 9 years ago

There seems to be a bug where if the third tree is loaded first, node AB|E is created and the first tree node ABC|D doesn't augment that node to be ABC|DE. This does occur when the first tree is loaded first.
((a,b,c),d); ((a,b,d),c); ((a,b),e);

blackrim commented 9 years ago

This is resolved with this fix a084c05. It was one line where we had a strict matching criterion of having all children for the incoming tree requiring a match to the lica node. This caused this behavior. By removing that requirement, it resolves the directionality of the lica mapping (for this example).

blackrim commented 9 years ago

With more testing, this can be pulled or just redone in master.