search

OpenTreeOfLife / treemachine

Source tree graph database
Other
16 stars 6 forks source link

Fix the child/parent induced subtree problem #225

Closed jar398 closed 8 years ago

jar398 commented 8 years ago

as noted here: https://github.com/OpenTreeOfLife/opentree/wiki/Open-Tree-of-Life-APIs#induced_subtree

and here: https://github.com/OpenTreeOfLife/feedback/issues/104

josephwb commented 8 years ago

? This is not a problem at all; it is working now.

jar398 commented 8 years ago

Excellent! I was just copying the issue over from the feedback repo. Will close both issues.

josephwb commented 8 years ago

Note that v2 would return the tree of valid ids as well as list which ids are bad. The v3 does not return any tree if any of the ids are bad (it just tells you which ones are bad).

jar398 commented 8 years ago

Yes of course I know that, I'm the one who made the change. The problem has been under discussion for a while now, but there hasn't been an issue for it, so I just created one: https://github.com/OpenTreeOfLife/treemachine/issues/226

josephwb commented 8 years ago

I believe I made the change, but regardless I was just making sure that this was still on the radar.

jar398 commented 8 years ago

We both made the change; you did it in treemachine, I did it in taxomachine.