Replace _asm int 3 - Githubissues

OpenTrespasser / JurassicParkTrespasser

A git-based fork of the Jurassic Park: Trespasser source code.

98 stars 24 forks source link

Replace _asm int 3 #121

Closed meekee7 closed 4 years ago

meekee7 commented 4 years ago

_asm int 3 triggers an interrupt which triggers a break in the debugger. Its effect is comparable to DebugBreak(). All active occurances of that instruction are replaced with the more intuitive Assert macro,

GamerDude27 commented 4 years ago

_asm int 3 also appears within the following files, please consider giving these the same treatment:

jp2_pc/Source/Lib/Loader/Loader.org (line 781)
jp2_pc/Source/Lib/Sys/Errors.hpp (line 91)
jp2_pc/Source/Lib/View/RasterD3D.cpp (line 934)

It also appears within the following file, but since this might be replaced later it might not be worth changing:

jp2_pc/Inc/smacker/RAD.H (lines 363 & 612)

meekee7 commented 4 years ago

Loader.org is not in active usage. I am unsure about the purpose of that file. (What is an .org file in this context?) The occurance in RasterD3D.cpp is in a comment, but has been replaced anyway. Changing the headers of third-party libraries is better avoided if possible.

GamerDude27 commented 4 years ago

After digging around for a bit all I couldn't find out much about the ORG filetype. I did find two cases where it's been used, but none of which fit the contents of the file we have here. Additionally, Loader.org seems to be no more than an older version of Loader.cpp. So I think it's safe to say that this file could be deleted.