OpenTrespasser / JurassicParkTrespasser

A git-based fork of the Jurassic Park: Trespasser source code.
99 stars 24 forks source link

AI - Potential pathfinding bug after resolving illegal memory access #21

Open meekee7 opened 4 years ago

meekee7 commented 4 years ago

Illegal memory writes in the A* path search corrupted memory and caused crashes in completely unrelated code sections when the player died and restarted the level.

The illegal memory writes were resolved with a quickfix: the search is not performed when an illegal memory write is likely to occur. This change may have had significant impact on the dino behavior. To me, they seem less reactive to the player, and standing still more often.

It should be investigated as to whether this change had any real impact and what can be done to restore the old behavior without bringing back the crashes.

meekee7 commented 4 years ago

The quickfix is included in commit #57f937c from PR #78. It is possible that the presumed dino behavior problems were caused by the now resolved problem from issue #20.