This is a big PR so I will summarize the things that are happening in it:
A new model is created, Talent. Talent model is the combination of User and Person models. Since the authentication mechanism is implement with it, deleting and re-generating the migration files were necessary. That is one of the two reasons this PR has many changes
The second reason why this PR has many changes is because I use black formatter in my editor. Every time I save, the whole file is formetted according to black. So, even though there is a one line change in a file, the whole file changes when I save
Sign up and sign in views are rewritten. The previous implementation was basic and not very good looking (at least for me :slightly_smiling_face: ) so I rewrote them
In addition to sign up view, another view is added which is used for filling out headline, overview and photo fields of a Talent model instance
Finally, I am aware that the template files are not using inheritance or any useful stuff that template engine provides. The reason why I did like this is to generate a pattern in template files. Since there is not many template files currently, it is hard to find a pattern. I could have gone with a generic pattern but that might change overtime
This PR will be followed by tests. I did not include them to make the PR bigger.
adrianmcphee
commented
1 year ago
This is a big PR so I will summarize the things that are happening in it:
Talent.Talentmodel is the combination ofUserandPersonmodels. Since the authentication mechanism is implement with it, deleting and re-generating the migration files were necessary. That is one of the two reasons this PR has many changesblackformatter in my editor. Every time I save, the whole file is formetted according toblack. So, even though there is a one line change in a file, the whole file changes when I saveheadline,overviewandphotofields of aTalentmodel instanceThis PR will be followed by tests. I did not include them to make the PR bigger.