Closed sachintom999 closed 11 months ago
Thank you for your contribution @sachintom999. Normally, we avoid using Javascript as much as possible. Instead, we use Hyperscript. However, in this case, using Hyperscript instead of Javascript introduces more complexity, in my opinion.
I just wanted to give you an idea of how we do things.
After you modify the PR according to the comments I just left, we can merge it.
Once again, thank you for your work!
hi @dogukanteber , Thank you for reviewing. Noted your point of using Hyperscript. Will keep in mind in the future PRs.
I have made the requested changes and pushed.
Well done, thanks!
Background
Demo
Solution
Note :
Remove Button
is hidden when user uploads a new picture, to avoid confusion. He can upload a new image to change the first uploaded image.Cancel
button is a potential solution.Remove Button
which deletes the original picture is retained.Changes
talent/templates/talent/profile_picture.html
Testing after fix